Refactor RawFeltVec
#3849
Open
Refactor RawFeltVec
#3849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
Open
cptartur
force-pushed
the
spr/master/b701265d
branch
from
f3341f3 to
975c55c
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
5be308b to
2fb1cab
Compare
Open
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
2fb1cab to
5f1378b
Compare
cptartur
force-pushed
the
spr/master/b701265d
branch
from
975c55c to
b529f57
Compare
This was referenced Nov 7, 2025
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
5f1378b to
61e2887
Compare
cptartur
force-pushed
the
spr/master/b701265d
branch
from
b529f57 to
a5347c6
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
61e2887 to
b6dbc2c
Compare
cptartur
force-pushed
the
spr/master/b701265d
branch
2 times, most recently
from
275f396 to
12fa2fe
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
b6dbc2c to
7a5f8b2
Compare
cptartur
requested review from
MKowalski8 and
ksew1
and removed request for
a team
ksew1
reviewed
Nov 11, 2025
| /// use this wrapper to NOT add extra length felt | ||
| /// useful e.g. when you need to pass an already serialized value | ||
| #[derive(Debug)] | ||
| pub struct NoLengthFeltVec<T>(pub Vec<T>) |
Member
There was a problem hiding this comment.
Maybe we could name it SerializedValue? As this i think is only usefull if value is serialized
cptartur
force-pushed
the
spr/master/b701265d
branch
from
12fa2fe to
f955261
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
7a5f8b2 to
69854b2
Compare
commit-id:30d7f8cd
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
69854b2 to
45efdc4
Compare
franciszekjob
approved these changes
Nov 12, 2025
| impl<T: CairoDeserialize, E: CairoDeserialize> CairoDeserialize for Result<T, E> { | ||
| fn deserialize(reader: &mut BufferReader<'_>) -> BufferReadResult<Self> { | ||
| let variant: Felt = reader.read()?; | ||
| let variant: usize = variant.to_usize().ok_or(BufferReadError::ParseFailed)?; |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| let variant: usize = variant.to_usize().ok_or(BufferReadError::ParseFailed)?; | |
| let variant = variant.to_usize().ok_or(BufferReadError::ParseFailed)?; |
ksew1
reviewed
Nov 19, 2025
| /// | ||
| /// Use this to omit adding extra felt for the length of the vector during serialization. | ||
| #[derive(Debug)] | ||
| pub struct SerializedValue<T>(pub Vec<T>) |
Member
There was a problem hiding this comment.
I would also drop generic. Only valid representation i would say is pub struct SerializedValue(pub Vec<Felt>)
| } | ||
| } | ||
|
|
||
| impl CairoDeserialize for SerializedValue<Felt> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
RawFeltVec#3849 ⬅